Skip to content

Revert "Use DeviceInfo in shelly (#58520)"#59315

Merged
balloob merged 1 commit intodevfrom
revert-58520-deviceinfo-shelly
Nov 7, 2021
Merged

Revert "Use DeviceInfo in shelly (#58520)"#59315
balloob merged 1 commit intodevfrom
revert-58520-deviceinfo-shelly

Conversation

@thecode
Copy link
Copy Markdown
Member

@thecode thecode commented Nov 7, 2021

This reverts commit df6351f.

Proposed change

Revert #58520 which cause entities to be detached from the device. Tested before and after revert and reverting this PR fixes the issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, @bieniu, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good for the future to try to understand why it is not working. Is mac not yet assigned when accessed in the constructor?

@balloob balloob merged commit 55cd1ff into dev Nov 7, 2021
@balloob balloob deleted the revert-58520-deviceinfo-shelly branch November 7, 2021 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entities of Shelly DW not added to device

5 participants